Skip to content

Commit

Permalink
Merge pull request #2602 from ag-grid/AG-9242-2
Browse files Browse the repository at this point in the history
AG-9242 Hide funnel series from minichart options
  • Loading branch information
alantreadway authored Sep 30, 2024
2 parents fae266d + 50fa06a commit 932ef35
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 1 addition & 7 deletions packages/ag-charts-types/src/chart/navigatorOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import type { AgBoxPlotSeriesOptions } from '../series/cartesian/boxPlotOptions'
import type { AgBubbleSeriesOptions } from '../series/cartesian/bubbleOptions';
import type { AgCandlestickSeriesOptions } from '../series/cartesian/candlestickOptions';
import type { AgCartesianSeriesOptions } from '../series/cartesian/cartesianSeriesTypes';
import type { AgConeFunnelSeriesOptions } from '../series/cartesian/coneFunnelOptions';
import type { AgFunnelSeriesOptions } from '../series/cartesian/funnelOptions';
import type { AgHeatmapSeriesOptions } from '../series/cartesian/heatmapOptions';
import type { AgHistogramSeriesOptions } from '../series/cartesian/histogramOptions';
import type { AgLineSeriesOptions } from '../series/cartesian/lineOptions';
Expand Down Expand Up @@ -122,8 +120,6 @@ export interface AgRangeAreaMiniChartSeriesOptions
extends Omit<AgRangeAreaSeriesOptions, CommonIgnoredProperties | 'label' | 'yLowName' | 'yHighName'> {}
export interface AgCandlestickMiniChartSeriesOptions
extends Omit<AgCandlestickSeriesOptions, CommonIgnoredProperties> {}
export interface AgConeFunnelMiniChartSeriesOptions extends Omit<AgConeFunnelSeriesOptions, CommonIgnoredProperties> {}
export interface AgFunnelMiniChartSeriesOptions extends Omit<AgFunnelSeriesOptions, CommonIgnoredProperties> {}

export interface AgOhlcMiniChartSeriesOptions extends Omit<AgOhlcSeriesOptions, CommonIgnoredProperties> {}

Expand All @@ -140,11 +136,9 @@ export type AgMiniChartSeriesOptions =
| AgRangeBarMiniChartSeriesOptions
| AgRangeAreaMiniChartSeriesOptions
| AgCandlestickMiniChartSeriesOptions
| AgConeFunnelMiniChartSeriesOptions
| AgFunnelMiniChartSeriesOptions
| AgOhlcMiniChartSeriesOptions;

type IgnoredMiniChartSeries = 'bullet';
type IgnoredMiniChartSeries = 'bullet' | 'funnel' | 'cone-funnel';
type VerifyAgMiniChartSeriesOptions = Record<NonNullable<AgCartesianSeriesOptions['type']>, string>;

// Verification checks for completeness/correctness.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ export const HIDDEN_SERIES_TYPES = ['AgBulletSeriesOptions'];
export const HIDDEN_API_INTERFACE_MEMBERS = {
AgChartThemeOverrides: ['bullet'],
AgGradientLegendOptions: ['stop'],
AgConeFunnelSeriesOptions: ['showInMiniChart'],
AgFunnelSeriesOptions: ['showInMiniChart'],
AgHeatmapSeriesOptions: ['showInLegend'],
AgSunburstSeriesHighlightStyle: ['item', 'series'],
AgSunburstSeriesOptions: ['showInLegend'],
Expand Down

0 comments on commit 932ef35

Please sign in to comment.