AG-13306 Migrate SeriesAreaManager to widgets/ framework
#2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
force-pushed
the
AG-13306/seriesAreaManager_widgets
branch
4 times, most recently
from
a1b8965
to
d27f2b7
Compare
olegat
force-pushed
the
AG-13306/seriesAreaManager_widgets
branch
3 times, most recently
from
3f6ac1b
to
1a37906
Compare
|
Snapshots automatically updated, please review before merge: diff |
1 similar comment
|
Snapshots automatically updated, please review before merge: diff |
olegat
force-pushed
the
AG-13306/seriesAreaManager_widgets
branch
2 times, most recently
from
50851ec
to
ed89205
Compare
|
Snapshots automatically updated, please review before merge: diff |
1 similar comment
|
Snapshots automatically updated, please review before merge: diff |
This changes the RegionManager to set the offsetX, offsetY values to be relative to the entire chart rather than relative to the series-area.
Som methods like Series.pickNode require relative offsetXY coords, but other methods like those for the tooltip updates require absolute canvasXY coords.
This fixes a bug where creating an annotation by clicking on a financial chart would delete the annotation when lifting the mouse button because both the 'drag-start' and 'click' events would get dispatched to annotations.ts.
These are relative to the sourceEvent.target but these offsets are being used as if they were relative to the series regions x/y position. Therefore, replace these properties with more explicit regionXY properties that calculated using the same technique as canvasXY.
The actual 'hover' logic is highlighting the datum immediately to the left of the expected datum by a fraction of a pixel. I think that we can live with that.
We need to make sure that we click on the series-area HTML element. Therefore, change the click coords.
|
Snapshots automatically updated, please review before merge: diff |
olegat
force-pushed
the
AG-13306/seriesAreaManager_widgets
branch
from
3bfa639
to
472c567
Compare
|
Snapshots automatically updated, please review before merge: diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13306
Depends on:
onchangeinto theSliderWidgetclass #2949SwitchWidget, sub-type ofButtonWidget#2945ProxyInteractiveServiceinto thewidgets/framework #2942