Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source PIM version check to allow ^1.7 or ~1.7 or similar #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bpresles
Copy link
Contributor

@bpresles bpresles commented Aug 3, 2018

The source Pim version check verify that the version string on composer.json container the "1.7." string.

But when the version string is like "^1.7", which means ">= 1.7 < 2.0" and so is perfectly valid, because it confirms that the source pim is a 1.7.x version, the check doesn't work because it doesn't contain a 1.7.* version string.

This check should allow ^1.7 or ~1.7 as source pim version, that's why it should only check for "1.7"

Related issue: #145

Definition Of Done

Q A
Added Specs Todo
Review and 2 GTM Todo
Micro Demo to the PO (Story only) Todo

Todo: Pending / Work in progress
OK: Done / Validated
-: Not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant