cleared dart analyze --fatal-infos and checked flutter test

akvelon · Oct 17, 2023 · e97702f · e97702f
1 parent 34f7878
commit e97702f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/lib/src/search/controller.dart b/lib/src/search/controller.dart
@@ -73,7 +73,7 @@ class CodeSearchController extends ChangeNotifier {
     patternFocusNode.unfocus();
     _hidingTimer?.cancel();
 
-    if (returnFocusToCodeField == true) {
+    if (returnFocusToCodeField) {
       _codeFieldFocusNode?.requestFocus();
     }
 
@@ -160,8 +160,8 @@ class CodeSearchController extends ChangeNotifier {
       return;
     }
 
-    final shouldDismiss = patternFocusNode.hasFocus == false &&
-        _codeFieldFocusNode?.hasFocus == false;
+    final shouldDismiss =
+        !patternFocusNode.hasFocus && _codeFieldFocusNode?.hasFocus == false;
 
     if (shouldDismiss) {
       hideSearch(returnFocusToCodeField: false);

diff --git a/test/src/code/string_get_changed_range_test.dart b/test/src/code/string_get_changed_range_test.dart
@@ -82,7 +82,7 @@ void main() {
         str1: 'abccde',
         str2: 'abcde',
         expected: [TextRange(start: 2, end: 2), TextRange(start: 3, end: 3)],
-      )
+      ),
     ];
     const affinities = [TextAffinity.upstream, TextAffinity.downstream];
 

diff --git a/test/src/folding/parsers/highlight_parser_go_test.dart b/test/src/folding/parsers/highlight_parser_go_test.dart
@@ -58,7 +58,7 @@ func (
         InvalidFoldableBlock(endLine: 6, type: FBT.braces),
         InvalidFoldableBlock(endLine: 6, type: FBT.braces),
         InvalidFoldableBlock(startLine: 6, type: FBT.parentheses),
-        InvalidFoldableBlock(endLine: 8, type: FBT.braces)
+        InvalidFoldableBlock(endLine: 8, type: FBT.braces),
       ];
       _Tester.parseAndCheck(
         mode: go,

diff --git a/test/src/folding/parsers/indent_parser_test.dart b/test/src/folding/parsers/indent_parser_test.dart
@@ -169,7 +169,7 @@ numbers = [1,
     5
 ]''',
           expected: [_FB(firstLine: 0, lastLine: 4, type: _T.indent)],
-        )
+        ),
       ];
 
       for (final example in examples) {

diff --git a/test/src/history/code_history_controller_test.dart b/test/src/history/code_history_controller_test.dart
@@ -76,10 +76,8 @@ void main() {
           final controller = await pumpController(wt, MethodSnippet.full);
           await wt.cursorEnd();
 
-          controller.value = controller.value;
           controller.value = controller.value.typed('a');
           controller.value = controller.value.typed('b');
-          controller.value = controller.value;
           controller.foldAt(0);
           controller.unfoldAt(0);