Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded pub packages for Flutter v3.13.6 #256

Merged
merged 8 commits into from
Oct 17, 2023

Conversation

nausharipov
Copy link
Collaborator

flutter pub outdated:
Showing outdated packages.
[*] indicates versions that are not the latest available.

Package Name  Current  Upgradable  Resolvable  Latest  

direct dependencies: all up-to-date.

dev_dependencies: all up-to-date.
all dependencies are up-to-date.
flutter test:
00:31 +271: All tests passed!
flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.6, on macOS 14.0 23A344 darwin-x64, locale en-KZ)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.83.0)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

example/lib/02.code_field % flutter run:
Screenshot 2023-10-11 at 19 25 34

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (149888a) 82.61% compared to head (2bbd103) 82.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   82.61%   82.60%   -0.02%     
==========================================
  Files         107      107              
  Lines        3163     3161       -2     
==========================================
- Hits         2613     2611       -2     
  Misses        550      550              
Files Coverage Δ
lib/src/search/controller.dart 78.46% <100.00%> (-0.65%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

controller.value = controller.value.typed('a');
controller.value = controller.value.typed('b');
controller.value = controller.value;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is useful to test that changing to the same value doesn't create a history record

Copy link
Collaborator

@yescorp yescorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nausharipov nausharipov merged commit d7e4beb into main Oct 17, 2023
5 checks passed
@nausharipov nausharipov deleted the flutter-pub-upgrade-11-10-23 branch October 17, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants