Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatable.js to not compare undefined keys during handleRowSel… #1575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2056,7 +2056,7 @@ export default class Datatable extends LightningElement {
this.outputSelectedRows = [];
if (allSelectedRecs) { // Keep selected rows in the same order as the original table
this.savePreEditData.forEach(rec => { // Check all records - mydata would just be the filtered records here
const isSelected = allSelectedRecs.some(srec => srec[this.keyField] === rec[this.keyField]);
const isSelected = allSelectedRecs.some(srec => srec[this.keyField] === rec[this.keyField] && srec[this.keyField] !== undefined && rec[this.keyField] !== undefined );
if (isSelected) {
this.outputSelectedRows = [...this.outputSelectedRows, rec];
}
Expand Down