[ui] Add and improve multiple UI tools for Photometric stereo #2444
+773
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-dl
added
feature
3 tasks
cbentejac
force-pushed
the
dev/qt6.6_phongImageViewer
branch
from
df3239d
to
8f8d8aa
Compare
cbentejac
force-pushed
the
dev/qt6.6
branch
4 times, most recently
from
44021cc
to
44ea158
Compare
cbentejac
force-pushed
the
dev/qt6.6_phongImageViewer
branch
from
8f8d8aa
to
68ee345
Compare
cbentejac
force-pushed
the
dev/qt6.6
branch
2 times, most recently
from
e7e2e2d
to
f818005
Compare
Use a single light entity instead of one per camera. Use directional light instead of point light. Add camera relative directional light controller.
Default camera up should be accurate and consistent with camera view center. Default camera up vector is not refresh or checked when default camera view center is set.
cbentejac
force-pushed
the
dev/qt6.6_phongImageViewer
branch
from
68ee345
to
a5cb28f
Compare
cbentejac
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the new QtAliceVision 2D viewer with toolbar and a new light direction controller.
A normal map with two light directions.
Add the ability to change the camera-relative light direction in the 3D viewer
Same object with two different light directions using the new light direction controller.
Improve
SphereDetectionwidget in order to handle automatic detection of calibration spheres.Automatically detected calibration sphere shown with the green circle.
Features list
SphereDetectionwidget in order to handle automatic detection of calibration spheres.Implementation remarks
This PR is based on the Qt6 migration branch: https://github.com/alicevision/Meshroom/tree/dev/qt6.6
Linked to QtAliceVision PR: alicevision/QtAliceVision#72