Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Python Script Editor Improvements #2587

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

waaake
Copy link

@waaake waaake commented Oct 28, 2024

Description

ScriptEditor Improvements

Features list

  • Script Editor now retains history of the code which is executed across Meshroom sessions.
  • Script Editor also highlights the code Syntax for Python
  • The output clearly distinguishes between executed code and the result of the code with different colors.

…xceptions

ScriptEditorManager now also allows the code to be saved and retrieved back. Exceptions are now shown with a better output to the user.
ScriptEditor is now part of a ColumnLayout in an MSplitView allowing more control over what is being viewed.
Python syntax within the script editor is now highlighted making it easier to understand and write smaller code in it.
@waaake waaake self-assigned this Oct 28, 2024
@cbentejac cbentejac added this to the Meshroom 2024.1.0 milestone Oct 28, 2024
horizontalAlignment: Text.AlignHCenter
Layout.fillWidth: true
}
MSplitView {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be discussed but I wonder if it wouldn't be better to have the split view be horizontal instead of vertical... As such, it's is pretty much unusable unless we expand the Script Editor's tab, which may not be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants