Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split meshroom.core.desc module into a package with submodules #2592

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

yann-lty
Copy link
Member

@yann-lty yann-lty commented Nov 4, 2024

Description

This PR does not bring any functional changes - it's only about code re-organization.
The main goal is to split the current meshroom/core/desc.py file into its own package with submodules, to apply the single-responsibility-principle and break a large module into more granular and manageable code units.

From:

meshroom/core/desc.py

To:

meshroom/core/desc/
    __init__.py
    attribute.py
    computation.py
    node.py

The API of the module has been preserved, therefore the node plugins are not impacted by this internal change.

Features list

  • Split meshroom/core/desc.py into a package with submodules while keeping git history.

Implementation remarks

To maintain git history in each new file, the original desc.py file has been git-moved to those new submodule paths on separate branches, which all got merged afterwards (hence the number of commits here).

@cbentejac cbentejac added this to the Meshroom 2024.1.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants