Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRG-1256: Update Ruby from 2.7.7 to 3.2.2 #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eddgrant
Copy link
Contributor

Hey folks 👋 , we noticed that bundler started failing our builds recently, indicating that Ruby 2.7.7 is now EOL:

ERROR: Error installing bundler:
The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with gem install bundler -v 2.4.22
bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.7.221.

We've updated our fork to use Ruby 3.2.2 and thought it might be helpful to offer the changes back.

Upgrading to 3.2.2 required the explicit addition of the rexml gem. rexml was a default gem in 2.7.7 whereas it is a bundled gem in 3.2.2.

We have also upgraded vcr to resolve this issue, which was observed running rspec:

warning: Exception in finalizer #<Proc:0x00007f4b983f5bc0 /home/egrant/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vcr-6.0.0/lib/vcr/library_hooks/webmock.rb:36 (lambda)>
/home/egrant/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vcr-6.0.0/lib/vcr/library_hooks/webmock.rb:36:in `block in global_hook_disabled_requests': wrong number of arguments (given 1, expected 0) (ArgumentError)

I'm not 100% certain if the vcr issue was related to the Ruby version upgrade, but it seemed sensible to include in the same PR.

Cheers,

Edd

Doing this as `bundler` started failing our builds today since Ruby 2.7.7 is EOL:

>ERROR:  Error installing bundler:
 	The last version of bundler (>= 0) to support your Ruby & RubyGems was 2.4.22. Try installing it with `gem install bundler -v 2.4.22`
 	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.7.221.

Upgrading to 3.2.2 required the explicit addition of the `rexml` gem. `rexml` was a default gem in 2.7.7 whereas it is a bundled gem in 3.2.2.

Also upgraded `vcr` to resolve this issue, which was observed running `rspec`:

>warning: Exception in finalizer #<Proc:0x00007f4b983f5bc0 /home/egrant/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vcr-6.0.0/lib/vcr/library_hooks/webmock.rb:36 (lambda)>
 /home/egrant/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/vcr-6.0.0/lib/vcr/library_hooks/webmock.rb:36:in `block in global_hook_disabled_requests': wrong number of arguments (given 1, expected 0) (ArgumentError)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant