-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 Update dependency chromedriver to v130 #39912
base: main
Are you sure you want to change the base?
Conversation
Looks like there was a change in Chrome that breaks some of these tests. The breakage results from a difference here: https://github.com/ampproject/amphtml/blob/main/extensions/amp-skimlinks/0.1/test/helpers.js#L13-L18 In Chrome 119, creating an In Chrome 120, these URLs result in an empty string in This issue only manifests itself inside the FakeWindow, it works as expected in a real window. The one thing I noticed is that Help! @ychsieh @erwinmombay |
e0725cf
to
0a489f1
Compare
0a489f1
to
5148c80
Compare
5148c80
to
ce8cc26
Compare
d290820
to
1ffe664
Compare
2831a06
to
c467835
Compare
c467835
to
e8da64f
Compare
75e1661
to
950eb01
Compare
9d99897
to
14f7dfa
Compare
14f7dfa
to
23aecd4
Compare
c39a894
to
fecc3f2
Compare
Pull request was closed
fecc3f2
to
61a1fdc
Compare
de669f2
to
9f79adc
Compare
3b184c1
to
9c7fa44
Compare
9c7fa44
to
fef2c68
Compare
07e06cd
to
3ca1f57
Compare
3ca1f57
to
94a0c3c
Compare
d9f74c4
to
c2e3544
Compare
464941b
to
6a18b90
Compare
6a18b90
to
5a84bc8
Compare
5a84bc8
to
1a1553f
Compare
1a1553f
to
87fb8f3
Compare
87fb8f3
to
191646f
Compare
This PR contains the following updates:
119.0.1
->130.0.0
See all other Renovate PRs on the Dependency Dashboard
How to resolve breaking changes
This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:
Release Notes
giggio/node-chromedriver (chromedriver)
v130.0.0
Compare Source
v129.0.4
Compare Source
v129.0.3
Compare Source
v129.0.2
Compare Source
v129.0.1
Compare Source
v129.0.0
Compare Source
v128.0.3
Compare Source
v128.0.2
Compare Source
v128.0.1
Compare Source
v128.0.0
Compare Source
v127.0.3
Compare Source
v127.0.2
Compare Source
v127.0.1
Compare Source
v127.0.0
Compare Source
v126.0.5
Compare Source
v126.0.4
Compare Source
v126.0.3
Compare Source
v126.0.2
Compare Source
v126.0.1
Compare Source
v126.0.0
Compare Source
v125.0.3
Compare Source
v125.0.2
Compare Source
v125.0.1
Compare Source
v125.0.0
Compare Source
v124.0.4
Compare Source
v124.0.3
Compare Source
v124.0.2
Compare Source
v124.0.1
Compare Source
v124.0.0
Compare Source
v123.0.4
Compare Source
v123.0.3
Compare Source
v123.0.2
Compare Source
v123.0.1
Compare Source
v123.0.0
Compare Source
v122.0.6
Compare Source
v122.0.5
Compare Source
v122.0.4
Compare Source
v122.0.3
Compare Source
v122.0.2
Compare Source
v122.0.1
Compare Source
v122.0.0
Compare Source
v121.0.2
Compare Source
v121.0.1
Compare Source
v121.0.0
Compare Source
v120.0.2
Compare Source
v120.0.1
Compare Source
v120.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "after 12am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.