Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom alphabet issues #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix custom alphabet issues #4

wants to merge 2 commits into from

Conversation

bir
Copy link

@bir bir commented Mar 5, 2020

No description provided.

bir added 2 commits March 4, 2020 20:18
@bir
Fix integer division truncate on guard_count
0b22e71 
When calculating guard_count:
length( alphabet )/ guard_div -> since both values are integers it will truncate the result (https://www.postgresql.org/docs/current/functions-math.html)
forcing length to float corrects the issue to spec.

Also removed extraneous drop statement.
@bir
Fix issue when len(separators) < min
8ca3c26
@braco braco mentioned this pull request May 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bir