Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug located in export_model_obj #5443

Closed
2 tasks done
SMoraisAnsys opened this issue Nov 18, 2024 · 3 comments · Fixed by #5444
Closed
2 tasks done

Bug located in export_model_obj #5443

SMoraisAnsys opened this issue Nov 18, 2024 · 3 comments · Fixed by #5444
Assignees
Labels
bug Something isn't working

Comments

@SMoraisAnsys
Copy link
Collaborator

Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

Recent changes to export_model_obj (see #5432) inverted the logic associated to the export into one or multiple objects. From my understanding, the argument export_as_single_objects had the right meaning : "exporting the model into multiple objects" and we should revert the changes that got merged. If the name is confusing then we might want to rename the argument, for example using export_as_multiple_objects to export multiple objects or export_as_single_object to export into one object.

NOTE: The changes make the pyaedt-examples repo failing. Specificly, this example https://github.com/ansys/pyaedt-examples/blob/main/examples/electrothermal/components_csv.py

If it is not clear

Steps To Reproduce

See above

Which Operating System are you using?

Windows

Which Python version are you using?

3.10

Installed packages

Doesn't matter

@SMoraisAnsys SMoraisAnsys added the bug Something isn't working label Nov 18, 2024
@SMoraisAnsys
Copy link
Collaborator Author

Pinging @lorenzovecchietti @Samuelopez-ansys for visibility

@lorenzovecchietti
Copy link
Contributor

You are absolutely right, sorry. In my mind, I read it without the final "s" and that changed completely the meaning. If you want, I can revert the changes, or you can do it.

@Samuelopez-ansys Samuelopez-ansys self-assigned this Nov 18, 2024
@SMoraisAnsys
Copy link
Collaborator Author

I'll do the changes and modify the name to make it more reader friendly. It is true that the name is a bit miss leading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants