Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Export model obj and rename argument #5444

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

Revert part of the changes in #5432 and rename the method argument to avoid miss reading.

Close #5443

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (2d1e606) to head (feacd90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5444      +/-   ##
==========================================
+ Coverage   84.37%   84.39%   +0.01%     
==========================================
  Files         140      140              
  Lines       58669    58669              
==========================================
+ Hits        49504    49515      +11     
+ Misses       9165     9154      -11     
---- 🚨 Try these New Features:

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit ed3aab4 into main Nov 18, 2024
41 checks passed
@SMoraisAnsys SMoraisAnsys deleted the fix/export_model_obj branch November 18, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in export_model_obj
2 participants