Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: general structure #356

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

maint: general structure #356

wants to merge 12 commits into from

Conversation

clatapie
Copy link
Collaborator

@clatapie clatapie commented Oct 24, 2024

This PRs updates the general structure of ast_tree.py and fixes a issues related to the CustomFunctions class.

Some adjustments were needed due to the fact arguments can be different between the custom functions and the autogenerated one. In this case, the arguments within the custom functions are the ones used.

@clatapie clatapie self-assigned this Oct 24, 2024
@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.06838% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (67f530a) to head (c540a5e).

Files with missing lines Patch % Lines
src/pyconverter/xml2py/custom_functions.py 81.35% 11 Missing ⚠️
src/pyconverter/xml2py/formatter.py 10.00% 9 Missing ⚠️
src/pyconverter/xml2py/ast_tree.py 88.63% 5 Missing ⚠️
src/pyconverter/xml2py/cli.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   84.55%   84.28%   -0.27%     
==========================================
  Files          13       13              
  Lines        2337     2418      +81     
==========================================
+ Hits         1976     2038      +62     
- Misses        361      380      +19     
Flag Coverage Δ
coverage 84.28% <76.06%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants