any to and from workflow #1839
Merged
any to and from workflow #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1839 +/- ##
==========================================
- Coverage 88.09% 88.02% -0.07%
==========================================
Files 83 83
Lines 9961 9963 +2
==========================================
- Hits 8775 8770 -5
- Misses 1186 1193 +7
|
PProfizi
approved these changes
Nov 18, 2024
PProfizi
reviewed
Nov 18, 2024
| @@ -185,6 +186,11 @@ def _type_to_new_from_get_as_method(self, obj): | |||
| self._api.any_new_from_any_collection, | |||
| self._api.any_get_as_any_collection, | |||
| ) | |||
| elif issubclass(obj, workflow.Workflow): | |||
| return ( | |||
There was a problem hiding this comment.
@cbellot000 is it normal for it to say it is not covered by testing?
There was a problem hiding this comment.
Hum no but I don't see it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.