Coinbase Wallet Adapter: Add supported transaction versions #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can I get you to consider implementing the Wallet Standard in Coinbase Wallet? It's a pretty quick nonbreaking change that can be made with no dependencies and it will make Coinbase Wallet work on most Solana apps without requiring an adapter at all. |
|
Yeah, it's on the roadmap! Not sure of timeline but it shouldn't be too long :) |
|
Cool! I added a changeset and ran the tests, can you check on the test failure? |
|
@jordaaash – fixed the type issue, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Coinbase Wallet adapter to properly list the supported transaction versions. Versioned transaction support was recently added to Coinbase Wallet.
I also cleaned up the TS a bit on the interface.
Tested locally that the correct tx versions are returned and that signing works as expected.