Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump last instance of actions/*-artifact to v4 #2329

Merged
merged 7 commits into from
Nov 15, 2024
Merged

chore: bump last instance of actions/*-artifact to v4 #2329

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a2b1d9
bump missed instance of v3
assignUser Nov 15, 2024
543478e
add name to go binaries
assignUser Nov 15, 2024
f8f161e
fix path
assignUser Nov 15, 2024
4252051
debug path
assignUser Nov 15, 2024
d6d35af
use merg-multiple
assignUser Nov 15, 2024
32ee8d8
debug dir-layout
assignUser Nov 15, 2024
4f5f3b7
remove debug
assignUser Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,9 @@ jobs:
popd

- name: Upload Go binaries
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: go-${{ matrix.os }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 errors on default when clobbering files of the same name, as this is a matrix job it was happening.

retention-days: 7
path: |
adbc/go/adbc/pkg/libadbc_driver_flightsql.*
Expand Down Expand Up @@ -167,13 +168,15 @@ jobs:
echo "schedule: ${{ github.event.schedule }}" >> $GITHUB_STEP_SUMMARY
echo "ref: ${{ github.ref }}" >> $GITHUB_STEP_SUMMARY

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
pattern: go-*
path: adbc/go/adbc/pkg
merge-multiple: true

- name: Copy Go binaries
run: |
pushd adbc/go/adbc/pkg/artifact
pushd adbc/go/adbc/pkg/
cp *.dll ../
cp *.so ../
cp *.dylib ../
Expand Down
Loading