Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4836] Fix Git submodules checkout failure in CI Build C task #4743

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

Pil0tXia
Copy link
Member

@Pil0tXia Pil0tXia commented Jan 12, 2024

Fixes #4836.

Motivation

Please read #4742 for bug information. This PR is just providing a code snippet for now. This PR can be merged now.

Please read #4836.

Modifications

Considering compile error and CI workflow file design oversight are two seperate subject, the original compile error issue #4742 will be remained to track compile error, and this PR corresponds to #4836 to address CI workflow file misconfiguration.

This PR won't cause CI failure. After #4742 is fixed, cpp option should be added in jobs.build.strategy.matrix.language array of ci.yml.

Updated a renamed label in stale workflow.

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e837f34) 17.59% compared to head (11d1546) 17.60%.
Report is 11 commits behind head on master.

❗ Current head 11d1546 differs from pull request most recent head 9043073. Consider uploading reports for the commit 9043073 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4743   +/-   ##
=========================================
  Coverage     17.59%   17.60%           
- Complexity     1774     1775    +1     
=========================================
  Files           797      797           
  Lines         29786    29786           
  Branches       2573     2574    +1     
=========================================
+ Hits           5242     5243    +1     
  Misses        24063    24063           
+ Partials        481      480    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@Pil0tXia Pil0tXia added help wanted Extra attention is needed and removed Stale labels Apr 5, 2024
@Pil0tXia Pil0tXia changed the title [ISSUE #4742] (Help Wanted) Enable CI Build C task [ISSUE #4836] Checkout Git submodules in CI Build C task Apr 14, 2024
@Pil0tXia Pil0tXia changed the title [ISSUE #4836] Checkout Git submodules in CI Build C task [ISSUE #4836] Fix Git submodules checkout failure in CI Build C task Apr 14, 2024
@Pil0tXia Pil0tXia removed the help wanted Extra attention is needed label Apr 14, 2024
@apache apache deleted a comment from github-actions bot Apr 14, 2024
@Pil0tXia Pil0tXia marked this pull request as ready for review April 14, 2024 10:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.47%. Comparing base (70f9892) to head (a40de33).
Report is 167 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4743      +/-   ##
============================================
+ Coverage     15.91%   16.47%   +0.56%     
- Complexity     1734     1819      +85     
============================================
  Files           897      910      +13     
  Lines         31982    32363     +381     
  Branches       2737     2786      +49     
============================================
+ Hits           5089     5331     +242     
- Misses        26413    26520     +107     
- Partials        480      512      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pil0tXia Pil0tXia closed this Apr 14, 2024
@Pil0tXia Pil0tXia reopened this Apr 14, 2024
@Pil0tXia Pil0tXia added the ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder) label Apr 14, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jul 28, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Sep 27, 2024
@harshithasudhakar harshithasudhakar merged commit c1c381b into apache:master Oct 21, 2024
12 checks passed
@Pil0tXia
Copy link
Member Author

@harshithasudhakar thx

@Pil0tXia Pil0tXia deleted the pil0txia/action_4742 branch October 28, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Failed to checkout Git submodules in CI Build C task
4 participants