bug: Paths and security schemes are optional (#427)

* chore: add minimal spec samples

* feat: set validation to false by default #425

internal/bundlegen/generateapiv2.go

@@ -131,7 +131,9 @@ func GenerateAPIProxyDefFromOASv2(name string,
 	}
 
 	// load security schemes
-	loadSecurityRequirementsv2(docModel.Model.Components.SecuritySchemes)
+	if docModel.Model.Components != nil && docModel.Model.Components.SecuritySchemes != nil {
+		loadSecurityRequirementsv2(docModel.Model.Components.SecuritySchemes)
+	}
 
 	apiproxy.SetDisplayName(name)
 	if docModel.Model.Info != nil {
@@ -274,6 +276,9 @@ func GenerateAPIProxyDefFromOASv2(name string,
 }
 
 func loadSecurityRequirementsv2(securitySchemes *orderedmap.Map[string, *v3.SecurityScheme]) (err error) {
+	if securitySchemes == nil {
+		return nil
+	}
 	for first := securitySchemes.First(); first != nil; first = first.Next() {
 		securityScheme := first.Value()
 		securitySchemesList.SecuritySchemes = append(securitySchemesList.SecuritySchemes, loadSecurityTypev2(first.Key(), securityScheme))
@@ -488,6 +493,9 @@ func getQuotaDefinitionv2(extension *yaml.Node) ([]quotaDef, error) {
 }
 
 func generateFlowsv2(paths *v3.Paths) (err error) {
+	if paths == nil {
+		return nil
+	}
 	for first := paths.PathItems.First(); first != nil; first = first.Next() {
 		pathMap, err := getHTTPMethodv2(first.Value(), first.Key())
 		if err != nil {

internal/cmd/apis/oascrtapisv2.go

@@ -184,7 +184,7 @@ func init() {
 	OasCreatev2Cmd.Flags().BoolVarP(&importProxy, "import", "",
 		true, "Import API Proxy after generation from spec")
 	OasCreatev2Cmd.Flags().BoolVarP(&validateSpec, "validate", "",
-		true, "Validate Spec before generating proxy")
+		false, "Validate Spec before generating proxy")
 	OasCreatev2Cmd.Flags().BoolVarP(&skipPolicy, "skip-policy", "",
 		false, "Skip adding the OAS Validate policy")
 	OasCreatev2Cmd.Flags().BoolVarP(&addCORS, "add-cors", "",

test/minspec.yaml

@@ -0,0 +1,34 @@
+# Copyright 2022 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+openapi: 3.0.2
+info:
+  version: 0.0.1
+  title: Minimal Spec
+  description: |
+    This specification contains the minimum information to generate an Apigee Proxy with PreFlow policies
+servers:
+  - url: https://my.example.com/api
+security:
+  - ApiKeyAuth: []
+x-google-ratelimit:
+  - name: test1_test
+    rate-literal: 10ps
+    identifier-ref: request.header.url #optional
+components:
+  securitySchemes:
+    ApiKeyAuth:
+      type: apiKey
+      in: header
+      name: X-API-KEY

test/minspec2.yaml

@@ -0,0 +1,24 @@
+# Copyright 2022 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+openapi: 3.0.2
+info:
+  version: 0.0.1
+  title: Minimal Spec
+servers:
+  - url: https://my.example.com/api
+x-google-ratelimit:
+  - name: test1_test
+    rate-literal: 10ps
+    identifier-ref: request.header.url #optional