Merge pull request #497 from apigee/issue496

bug: fixes type conversion for kvm entries #496
apigee · Jul 7, 2024 · d23221b · d23221b
2 parents 485afef + b450bda
commit d23221b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/internal/cmd/kvm/crtentry.go b/internal/cmd/kvm/crtentry.go
@@ -40,6 +40,7 @@ var CreateEntryCmd = &cobra.Command{
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
 		cmd.SilenceUsage = true
+		value = getKVMString(value)
 		_, err = kvm.CreateEntry(proxyName, mapName, keyName, []byte(value))
 		return
 	},

diff --git a/internal/cmd/kvm/entries.go b/internal/cmd/kvm/entries.go
@@ -15,6 +15,9 @@
 package kvm
 
 import (
+	"fmt"
+	"strconv"
+
 	"github.com/spf13/cobra"
 )
 
@@ -36,3 +39,16 @@ func init() {
 	EntryCmd.AddCommand(ImpEntryCmd)
 	EntryCmd.AddCommand(UpdateEntryCmd)
 }
+
+func getKVMString(value string) string {
+	var err error
+	// convert any boolean, float or integer to string
+	if _, err = strconv.ParseBool(value); err == nil {
+		value = fmt.Sprintf("\"%s\"", value)
+	} else if _, err = strconv.ParseInt(value, 10, 0); err == nil {
+		value = fmt.Sprintf("\"%s\"", value)
+	} else if _, err = strconv.ParseFloat(value, 0); err == nil {
+		value = fmt.Sprintf("\"%s\"", value)
+	}
+	return value
+}
diff --git a/internal/cmd/kvm/updentry.go b/internal/cmd/kvm/updentry.go
@@ -40,6 +40,7 @@ var UpdateEntryCmd = &cobra.Command{
 	},
 	RunE: func(cmd *cobra.Command, args []string) (err error) {
 		cmd.SilenceUsage = true
+		value = getKVMString(value)
 		_, err = kvm.UpdateEntry(proxyName, mapName, keyName, []byte(value))
 		return
 	},