Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create github action and include in Circle build pipeline #538

Merged
merged 14 commits into from
Jul 12, 2024
Merged

Create github action and include in Circle build pipeline #538

merged 14 commits into from
Jul 12, 2024

Conversation

clenfest
Copy link
Contributor

Build and test x86 mac architecture through a github action

@clenfest clenfest requested review from a team as code owners July 12, 2024 17:16
duckki
duckki approved these changes Jul 12, 2024
View reviewed changes
Copy link

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the x86 builds ran on this PR branch and I could download the artifact and run it locally. I just have a minor comment on the unused environment variables. Otherwise, it looks good to me!

.github/workflows/tests-mac-x86.yml Outdated Show resolved Hide resolved
@clenfest clenfest enabled auto-merge (squash) July 12, 2024 22:03
@clenfest clenfest merged commit 132eb03 into main Jul 12, 2024
13 checks passed
@clenfest clenfest deleted the clenfest/gh_action branch July 12, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckki duckki duckki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clenfest @duckki