CodeSandbox setup #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! I just merged #52 which merges the client and server together to run more like a traditional full-stack app. The server now serves the HTML sent to the client which means the app now runs on a single port 3000. This might affect your setup here, so just wanted you to be aware! Hopefully this simplifies some things for the codesandbox setup. |
|
Yup, already saw that. Thanks for thinking of me here :) |
|
I believe this is ready for a first round of review. There are still some open questions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening a PR so I don't lose track of my draft branch :D
https://codesandbox.io/p/github/apollographql/spotify-showcase/draft/infallible-sun