Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor I/O classes #129

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Refactor I/O classes #129

wants to merge 3 commits into from

Conversation

apriha
Copy link
Owner

@apriha apriha commented Apr 27, 2021

Simplifies Reader and Writer classes. Adds class-based parsers (fixes #119).

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #129 (4a0fe35) into develop (68ca13e) will increase coverage by 0.10%.
The diff coverage is 97.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
+ Coverage    92.87%   92.97%   +0.10%     
===========================================
  Files            8        8              
  Lines         1473     1495      +22     
  Branches       254      252       -2     
===========================================
+ Hits          1368     1390      +22     
  Misses          66       66              
  Partials        39       39              
Impacted Files Coverage Δ
src/snps/io/writer.py 86.48% <85.71%> (-0.59%) ⬇️
src/snps/io/reader.py 97.58% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ca13e...4a0fe35. Read the comment docs.

@apriha
Copy link
Owner Author

apriha commented Apr 27, 2021

Hi @willgdjones , @afaulconbridge , please check out these changes and let me know what you think. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants