Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving least squares interpolation #946
Moving least squares interpolation #946
Changes from 29 commits
0207ebb
7b9e389
c4b7190
139ef2c
8b499ac
1478078
a5c6e31
fbaf7f3
1fc3915
3943b47
ced621e
01271f6
4e8c483
03afffc
c0bd551
07ba1e0
a743130
d2653ba
b07d0f0
e2854ab
afc0072
a2e5a74
d13afe5
ef2bebb
da7c6ee
b945686
728458a
b1aca0c
ff7e6c7
46ae5fd
37161b9
6529ca0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment (nothing to be done here): There is an option in clang-format-16 for adding a newline at the end of the file, see https://releases.llvm.org/16.0.0/tools/clang/docs/ClangFormatStyleOptions.html#insertnewlineateof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change this? As far as I can tell it is not needed in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The polynomial basis is computed on the device and needs to ensure that the argument given is a point.
KOKKOS_FUNCTION
is necessary to compile,constexpr
could be removed