-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving least squares (extra fixes) #992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
reviewed
Dec 23, 2023
src/interpolation/details/ArborX_InterpDetailsCompactRadialBasisFunction.hpp
Show resolved
Hide resolved
src/interpolation/details/ArborX_InterpDetailsCompactRadialBasisFunction.hpp
Show resolved
Hide resolved
mrlag31
force-pushed
the
mls-extra-fixes
branch
2 times, most recently
from
December 27, 2023 14:46
4d00940
to
620ac7e
Compare
Using primitives instead of access values in callback
mrlag31
force-pushed
the
mls-extra-fixes
branch
from
December 27, 2023 15:57
620ac7e
to
9f99b90
Compare
This is also the base for two extra features
|
aprokop
approved these changes
Dec 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds miscellaneous fixes for #946. Those are the fixes in no particular order:
AccessValues
instead ofAccessTraits
MovingLeastSquares
classindices
andsource_view
viewsKOKKOS_FUNCTION
andKOKKOS_INLINE_FUNCTION
slice_lengths
static reference inevaluatePolyBasis
This PR is here to discuss how to split off the changes and track them. It is not for immediate merge.