Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(update): Added Job summary for lint.yml workflow #2755

Closed
wants to merge 7 commits into from
Closed

Feat(update): Added Job summary for lint.yml workflow #2755

wants to merge 7 commits into from

Conversation

itsaviral2609
Copy link
Contributor

@itsaviral2609 itsaviral2609 commented Jul 26, 2023

What type of PR is this?

The following PR adds job summary for lint.yml workflow which on successful workflow of lint.yml generates a summary of it

Screenshot from 2023-07-26 12-16-59

Screenshot from 2023-07-26 12-17-15

Screenshot from 2023-07-26 12-17-35

Screenshot from 2023-07-26 12-17-42

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2227

Special notes for your reviewer:

Please review my PR and suggest any changes if any 😄

┆Issue is synchronized with this Jira Task by Unito

The following PR adds job summary for lint.yml workflow

Fixes: #2227
The following PR adds job summary for lint.yml workflow

Fixes: #2227
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f7ebc6d) 16.21% compared to head (06f00b2) 16.21%.

❗ Current head 06f00b2 differs from pull request most recent head c871f13. Consider uploading reports for the commit c871f13 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2755   +/-   ##
=======================================
  Coverage   16.21%   16.21%           
=======================================
  Files         160      160           
  Lines       12559    12559           
  Branches      487      487           
=======================================
  Hits         2037     2037           
  Misses      10353    10353           
  Partials      169      169           
Flag Coverage Δ
unittests 16.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kannon92 kannon92 requested a review from dejanzele July 26, 2023 12:43
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2227 (comment)

I believe you are aware of this but moving that thread to here. Please update this PR with these changes and then re-request a review.

@itsaviral2609 itsaviral2609 closed this by deleting the head repository Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure all workflows use Job Summaries for easy job overview
2 participants