Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Scheduler Metrics #3804

Merged
merged 54 commits into from
Aug 24, 2024
Merged

Refactor Scheduler Metrics #3804

merged 54 commits into from
Aug 24, 2024

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Jul 20, 2024 •
edited
Loading

  • Consolidates scheduler.schedulermetrics and metrics.metrics into a single place, with single configuration object.
  • Simplifies metrics.metrics

d80tb7 added 30 commits July 16, 2024 07:25
@d80tb7
wip
dc0c95a 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
Merge branch 'master' of github.com:armadaproject/armada into f/chris…
4a43e16 
…ma/metrics-new
@d80tb7
lint
12afcba 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
c6c374e 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
08342db 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
ac09e98 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
0676acc 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
24457df 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
e8ab561 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
remove unnecessary classes
f55923a 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix tests
aa14c55 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix tests
0a767fb 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
lint
f3d2838 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix integration test
0fe3214 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
unit test
62de8a2 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
unit test
e1cd3e6 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
go mod tidy
48097e1 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
lint
b15df0f 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
lint
8d91b50 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
8959e35 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
f04cdae 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
c2ee828 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
merge master
826a15a 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
a134c00 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
bf491ea 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
d92660a 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
Merge branch 'master' of github.com:armadaproject/armada into f/chris…
7685435 
…ma/metrics-new
@d80tb7
wip
e035b85 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
1bac801 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
e196e22 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix compilation
3d60449 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
more tests
e5e6308 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
more tests
b9e85b8 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
b621711 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
merge master
602a6a2 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix merge conflict
2c6844d 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
minor fixes
16dd06f 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
better names
4fcc715 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
fix test
2766ff7 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
add counters
f5a8083 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
wip
b3f86d2 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
merge master
41fa74e 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
add back reset
c7057aa 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
add back reset
7ff6aed 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
add back reset
d00d084 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
register metrics
1fe31de 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
Merge branch 'master' of github.com:armadaproject/armada into f/chris…
468b3af 
…ma/metrics-new
@d80tb7
lint
a4d1d5c 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7 d80tb7 changed the title [WIP] Better Metrics Refactor Scheduler Metrics Aug 9, 2024
@d80tb7
fix metric names
ba7de77 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7
Merge branch 'master' of github.com:armadaproject/armada into f/chris…
064b54d 
…ma/metrics-new
@d80tb7
review comments
6a35699 
Signed-off-by: Chris Martin <chris@cmartinit.co.uk>
@d80tb7 d80tb7 enabled auto-merge (squash) August 24, 2024 08:18
@d80tb7 d80tb7 merged commit 523771f into master Aug 24, 2024
27 of 28 checks passed
@d80tb7 d80tb7 deleted the f/chrisma/metrics-new branch August 24, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertdavidsmith robertdavidsmith robertdavidsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d80tb7 @robertdavidsmith