Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the generators that are not yet supported in V3 #979

Closed
Amzani opened this issue Feb 27, 2024 · 9 comments · Fixed by #982
Closed

Disable the generators that are not yet supported in V3 #979

Amzani opened this issue Feb 27, 2024 · 9 comments · Fixed by #982
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Amzani
Copy link
Collaborator

Amzani commented Feb 27, 2024

Some generators don't support yet V3

  • @asyncapi/dotnet-nats-template
  • @asyncapi/ts-nats-template
  • @asyncapi/python-paho-template
  • @asyncapi/nodejs-ws-template
  • @asyncapi/java-spring-cloud-stream-template
  • @asyncapi/go-watermill-template
  • @asyncapi/java-spring-template
  • @asyncapi/nodejs-template
  • @asyncapi/java-template
  • @asyncapi/php-template

Current behavior

In V3 document (example) not supported generators are displayed even though they are not supported.

Screenshot 2024-02-27 at 13 31 24

Expected behavior

For a better Developer Experience(DX):

  • Disable not supported generators
  • Inform the user
Screenshot 2024-02-27 at 13 38 44

Tracking link: #980

Note: Currently there is a bug in the Doc generation for V3, the fix is WIP asyncapi/cli#1200

@Amzani Amzani added the enhancement New feature or request label Feb 27, 2024
@Amzani Amzani added the good first issue Good for newcomers label Feb 27, 2024
@devilkiller-ag
Copy link
Member

Hi @Amzani Can I work on this issue?

@Amzani
Copy link
Collaborator Author

Amzani commented Feb 27, 2024

Sure @devilkiller-ag please take it

@kalpesh-d
Copy link
Contributor

Hi @Amzani, I noticed there's no indication of which generators are supported. Do you think it would be a good idea to include an array listing the supported generators?

@Amzani
Copy link
Collaborator Author

Amzani commented Feb 27, 2024

@kalpesh-d it's in the description

@hitenvats16
Copy link

Is this issue is fixed now?

@ashmit-coder
Copy link
Contributor

ashmit-coder commented Mar 1, 2024

Is this issue is fixed now?

Yes it is currently being resolved and is near finishing.

@devilkiller-ag
Copy link
Member

Sorry @Amzani, I got busy with my exams this week, I was planning to resolve this today. @kalpesh-d This issue was assigned to me. You should have asked here before starting your work on this. I am happy that you resolved this issue, but kindly keep in mind to ask the assignee before working on it out of the blue.

@kalpesh-d
Copy link
Contributor

@devilkiller-ag, I apologize for not checking with you first.

Amzani added a commit that referenced this issue Mar 5, 2024
* fix: Disable unsupported generators for AsyncAPI V3 (#979)

* Refactored GeneratorModal for AsyncAPI V3 support and removed [TRACKING_LINK]

* fix lint errors

* fix warning

---------

Co-authored-by: samz <samir.amzani@gmail.com>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Studio - Kanban Mar 5, 2024
@emivalsilvajr
Copy link

Hi, trying to generate docs for v3 using markdown and the studio.asyncapi.com is reporting that is not supported. Is that something that I am missing?
Captura de Tela 2024-08-22 às 11 48 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
6 participants