Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable unsupported generators for AsyncAPI V3 (#979) #982

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

kalpesh-d
Copy link
Contributor

Description

  • Updated the GeneratorModal component to disable unsupported generators for AsyncAPI V3.
  • Added a warning message for unsupported generators with a link to the tracking page.

Related issue(s)
Fixes #979

Copy link

changeset-bot bot commented Feb 27, 2024

⚠️ No Changeset found

Latest commit: 753415c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 753415c
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65e1f866f10e930008769c61
😎 Deploy Preview https://deploy-preview-982--modest-rosalind-098b67.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 753415c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65e1f866985d10000807231a
😎 Deploy Preview https://deploy-preview-982--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kalpesh-d for this PR.
This behavior should only happen for AsyncAPI V3 documents.
For older versions all generators are working - try with this for instance

apps/studio/src/components/Modals/ConfirmModal.tsx Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kalpesh-d kalpesh-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Amzani, Changes have been made to ensure that only AsyncAPI V3 documents exhibit this behavior, while older versions continue to support all generators.

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some linting errors

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor Author

@kalpesh-d kalpesh-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Amzani, I've addressed linting errors in the code. Everything should be in order now.

@Amzani
Copy link
Collaborator

Amzani commented Mar 5, 2024

/rtm

@Amzani Amzani merged commit cacd18c into asyncapi:master Mar 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disable the generators that are not yet supported in V3
3 participants