Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add architecture considerations document #739

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Jul 13, 2023

Description

Some initial considerations for the new Studio architecture.

Related issue(s)
#725

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2023

⚠️ No Changeset found

Latest commit: 106fe94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 106fe94
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/64afbd95106d1e000850e791
😎 Deploy Preview https://deploy-preview-739--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 106fe94
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/64afbd957349c300082a0305
😎 Deploy Preview https://deploy-preview-739--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fmvilas fmvilas mentioned this pull request Jul 13, 2023
3 tasks
@Shurtu-gal
Copy link
Collaborator

@fmvilas The problems faced using the current services may also be mentioned.
Going forward, what I propose to do is :-

  • Hoist shared components such as editor to context and pass them onto hooks example
  • Use hooks to share the functions and store application logic. example

This works well currently; even things such as navigation in the editor, template and visualiser are working correctly.

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas
Copy link
Member Author

fmvilas commented Jul 13, 2023

@Shurtu-gal I wonder if that's something related to the current architecture. Maybe, with the new architecture, we can find a way to make this easier? I mean, with a couple of exceptions, everything should be executable on the server and on the client. What do you think?

@Shurtu-gal
Copy link
Collaborator

Yeah, if we separate it instead of maintaining it on the client. These problems will be solved by themselves. This way, the object of concern may be separated, and services may be exposed as APIs.

P.S.:- But things like navigation and theme setting would have to be handled on the client side using context and hooks.

@Amzani
Copy link
Collaborator

Amzani commented Jul 14, 2023

@fmvilas @Shurtu-gal I think it's a valid question that we should cover under the new architecture ? When do we use Hooks ? and also How to share state between components ? do we use React Context or Zustand

@fmvilas
Copy link
Member Author

fmvilas commented Jul 18, 2023

Agree. We'll have to address all these questions. Who wants to take the lead here?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 23, 2023
@github-actions github-actions bot closed this Mar 23, 2024
Copy link
Collaborator

Amzani commented Mar 26, 2024

Still relevant

@KhudaDad414 KhudaDad414 reopened this Mar 26, 2024
@KhudaDad414 KhudaDad414 removed the stale label Mar 26, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants