Fix some small bugs in install.sh #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
force-pushed
the
fix_install_freebsd
branch
2 times, most recently
from
242d734
to
dcaf469
Compare
Fixes bashism in the `args` test in `install.sh` that won't work with POSIX `sh`, or `bash` in `sh` mode. Modified the pre-installation check to test if the currently installed version is the same rather than just for the presence of the `atomvm_packbeam` directory so that upgrading to other versions will be possible with future releases. Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
force-pushed
the
fix_install_freebsd
branch
from
dcaf469
to
d7356c0
Compare
fadushin
reviewed
Nov 4, 2023
fadushin
requested changes
Nov 4, 2023
UncleGrumpy
force-pushed
the
fix_install_freebsd
branch
from
8f59922
to
d7356c0
Compare
fadushin
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bashism in the
argstest ininstall.shthat won't work with POSIXsh, orbashinshmode.Modified the pre-installation check to test if the currently installed version is the same rather than just for the presence of the
atomvm_packbeamdirectory so that upgrading to other versions will be possible with future releases.Also adds generated
docdirectory to.gitignore.