chore: separate atkey upload to a service in at_onboarding_flutter #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
commented
Nov 14, 2024
| @@ -1,184 +1,5 @@ | |||
| import 'dart:io'; | |||
| library at_onboarding_legacy; | |||
There was a problem hiding this comment.
moved to src/at_onboarding.dart
XavierChanth
commented
Nov 14, 2024
| error, //Authenticate error | ||
| cancel, //User canceled | ||
| } | ||
| library at_onboarding_result_legacy; |
There was a problem hiding this comment.
moved to src/at_onboarding_result
XavierChanth
commented
Nov 14, 2024
| import 'package:at_utils/at_logger.dart'; | ||
| import 'package:file_picker/file_picker.dart'; | ||
|
|
||
| class AtKeysFileUploadService { |
There was a problem hiding this comment.
The service extracted from the onboarding home screen
XavierChanth
commented
Nov 14, 2024
| loading = false; | ||
| }); | ||
| return; | ||
| Future<void> _uploadKeyFile() async { |
There was a problem hiding this comment.
This calls the new service, and listens to the progress stream, updating the UI accordingly. The actual logic behind when UI changes occur is the same
|
@gkc I originally planned to do a lot more, but I believe this service extraction is the minimum required changeset for us to make the planned improvements to the NoPorts desktop onboarding UX. |
|
Setting back to draft, need to make a few more changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
packagetosrc/so we have better grasp over our public API.- How I did it
- How to verify it
- Description for the changelog
chore: separate atkey upload to a service in at_onboarding_flutter