-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #236
Support Python 3.12 #236
Conversation
Reviewer's Guide by SourceryThe changes implement Python 3.12 support by conditionally disabling the Artifactory backend, which is incompatible with Python 3.12. The implementation involves modifying test files to skip Artifactory-related tests when running on Python 3.12 and updating the CI configuration to handle Python 3.12 builds differently. Updated class diagram for test_api functionclassDiagram
class test_api {
+test_api(hosts, name, host, repository, expected_class)
}
note for test_api "Refactored to use expected_class instead of cls and handle Python 3.12 compatibility"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add support for Python 3.12 by disabling the Artifactory backend for Python 3.12, as it does not support Python 3.12 at the moment. All other Python versions are not affected by this change. Disabling is managed inside
pyproject.toml
by not installingdohq-artifactory
for Python 3.12 or higher.By disabling Artifactory for Python 3.12,
import audbackend
will no longer fail for Python 3.12 as reported in audeering/audb#432.I updated the installation docs to mention, that Artifactory is not available at the moment.
Summary by Sourcery
Add support for Python 3.12 by updating the CI configuration and refactoring tests to exclude the Artifactory backend, which is not compatible with Python 3.12.
New Features:
Enhancements:
CI: