-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Datacard.segment_duration_distribution #95
Conversation
4d70293
to
499f41a
Compare
499f41a
to
83da894
Compare
83da894
to
f871fa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to produce a review for this issue, I have limited myself to building the documentation. The code builds flawlessly. I can render the documentation, and indeed, the public datasets contain a database that has segments - vadtoolkit which is pleasant to work with. For now I see this enough as a functional check.
There are two minor things that made me wonder:
1. convention of html-build location
I ususally expect locally built documentation in build/html/
. For this project it deviates and is now at build/sphinx/html/
. Have the conventions changed?
Or is this a one off?
2. Check of produced documentation file paths - sphinx-src-dir
-
the location of segment distribution files in cache pans out:
/.cache/audbcards/vadtoolkit/1.1.0/vadtoolkit-1.1.0-segment-duration-distribution.png
foolows the filename convention in the documentation, and the location in<cache-root>/<dataset-name>/<dataset-version>/
is also correct. -
the location of the image file in sphinx-src- dir I find more difficulat. Within sphinx-src-dir I have this file:
~/work/tools-public/audbcards/build/sphinx/html/_images/vadtoolkit-1.1.0-segment-duration-distribution.png
.
What would the variables in<sphinx-src-dir>/<path><dataset-name>/
need to be expanded to in order to get this valid?
1. convention of html-build locationYou are correct, if asked I would recommend the following command to build the docs: $ python -m sphinx docs/ build/html -b html I think the old I created #102 to change this for |
2. Check of produced documentation file paths - sphinx-src-dir
What do you mean by the last sentence? |
This was a backtick error: |
2. Check of produced documentation file paths - sphinx-src-dirWe start from cache at the position you located correctly: audbcards/audbcards/core/datacard.py Lines 402 to 409 in f871fa1
Which means it will be located at
audbcards/audbcards/sphinx/__init__.py Lines 133 to 141 in f871fa1
This means, you will not find |
Makes use of
audbcards.Dataset.segments
andaudbcards.Dataset.segment_durations
, introduced in #31 to addaudbcards.Datacard.segment_duration_distribution
.API documentation
Example dataset page