docs: Clarify metric collection methods for NTH modes #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Explained how Prometheus metric collection differs between IMDS and Queue modes. * Added a warning about serviceMonitor and podMonitor being Prometheus Operator resources. * Updated Queue mode to include two methods for metrics collection: using serviceMonitor with the Prometheus Operator or adding the aws-node-termination-handler service in `scrape_configs`. * Provided an example `scrape_configs` for Prometheus in the Helm chart. * Updated IMDS mode to mention podMonitor for metrics collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updated the README to clarify the Prometheus metric collection methods for NTH in IMDS and Queue modes, to ensure users understand how to configure Prometheus based on the NTH mode they are using.
Explained how Prometheus metric collection differs between IMDS and Queue modes.
Added a warning about serviceMonitor and podMonitor being Prometheus Operator resources.
Updated Queue mode to include two methods for metrics collection: using serviceMonitor with the Prometheus Operator or adding the aws-node-termination-handler service in
scrape_configs.Provided an example
scrape_configsfor Prometheus in the Helm chart.Updated IMDS mode to mention podMonitor for metrics collection.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.