modules: add tty #675
Open
modules: add tty #675
+141
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahaoboy tests are failing because you need to mark it as external in esbuild config inside |
nabetti1720
reviewed
Nov 14, 2024
tests/unit/tty.test.ts
Outdated
Comment on lines
3
to
17
| describe("tty", () => { | ||
| it("isatty", () => { | ||
| // FIXME: in the test environment, isatty is always false | ||
| expect([ | ||
| isatty(1), | ||
| isatty(2), | ||
| isatty(3), | ||
| isatty(4), | ||
| ]).toEqual([ | ||
| false, | ||
| false, | ||
| false, | ||
| false, | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
Do I get the same results if I run it on the laptop at hand?
There was a problem hiding this comment.
The results of running the command line are correct. I suspect that llrt test uses redirection or other unknown behaviors, which causes all false to be returned in the test.
import { isatty } from 'tty'
console.log(
isatty(1),
isatty(2),
isatty(3),
isatty(4),
)
llrt ./a.js
true true false false
There was a problem hiding this comment.
I figured that would probably be the case. This is a little troubling because I always run the test suite on the laptop at hand to make sure it is error free before shipping...
There was a problem hiding this comment.
Now only the return value type is checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add tty module and use libc to implement tty.isatty function
Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.