Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action #110

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Add github action #110

merged 2 commits into from
Nov 4, 2024

Conversation

baudehlo
Copy link
Owner

No description provided.

@baudehlo baudehlo mentioned this pull request Nov 1, 2024
Merged
@Fordi
Copy link
Contributor

Fordi commented Nov 4, 2024

Run git pull --rebase origin master on your patch branch. The fs-ext.cc in there still has NODE_MODULE at the bottom, not NODE_MODULE_INIT - that is, it's not up-to-date with master.

@baudehlo baudehlo merged commit 4cb7c1a into master Nov 4, 2024
3 checks passed
@baudehlo
Copy link
Owner Author

baudehlo commented Nov 4, 2024

Thanks for your help @Fordi - I've published your fixes now as 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baudehlo @Fordi