feat: realm request ui #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a globally accessible modal component
ad djest config for unit tests
add form for new custom realms
add custom realm request dashboard
style tweaks
remove commented code
install and run pre-commit
swap out splash svg
merge backend changes
integrate with backend changes
merge in dev
merge in dev
organize test file
fix dir in ci pipeline
jlangy
force-pushed
the
sso-team-1002
branch
from
e1a6b8e
to
76bc0a4
Compare
make test yaml file
unskip test case
NithinKuruba
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were quite a few more changes in the mockups than I initially thought once I got into them, this got a bit large. I added a couple things:
The delete is not hooked up to an api route yet, I don't think one exists so far. The button is just there as a placeholder, but that view is only for our internal team.
I refactored the GET for all realms a little bit just so that it could be reused in getServerSideProps for initial page load, but left it essentially the same just moved stuff to a function.