Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression tests #121

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix: regression tests #121

merged 5 commits into from
Apr 12, 2024

Conversation

jlangy
Copy link
Contributor

@jlangy jlangy commented Apr 12, 2024 •
edited
Loading

Some small fixes:

  • Add shell param to roketchat notification
  • Add missing test files to github action sections
  • Typescript cleanup
  • Scroll elements into view before clicking, in case they are off the page

@jlangy
chore: add shell
5d36c09 
add shell setting to gh action
@jlangy
chore: prereqs
8417605 
add prereqs to runner
@jlangy
test: mouseover
0ff8c39 
use mouseover to wait for load
@jlangy
test: scroll
3c93cf3 
test scrolling element into view
@jlangy
fix: scroll into view
750b944 
scroll elements into view before force clicks
@jlangy jlangy added the bug Something isn't working label Apr 12, 2024
@jlangy jlangy changed the title Ssoteam 1714 fix: regression tests Apr 12, 2024
@jlangy jlangy merged commit de730f6 into main Apr 12, 2024
9 of 14 checks passed
@jlangy jlangy deleted the ssoteam-1714 branch April 12, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcshiftsolutions arcshiftsolutions arcshiftsolutions approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlangy @arcshiftsolutions