Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SU24 / Bug Fixes & Refactoring #329

Merged
merged 15 commits into from
Jul 24, 2024
Merged

SU24 / Bug Fixes & Refactoring #329

merged 15 commits into from
Jul 24, 2024

Conversation

cycomachead
Copy link
Member

  • Cleanup handling of email templates
  • Delete some old code/labels
  • Reorg the teacher model in prep for deleting some stuff.
  • add some basic EmailTemplate test cases.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.31%. Comparing base (49575e3) to head (2019df1).

Files Patch % Lines
app/models/teacher.rb 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   89.24%   89.31%   +0.06%     
==========================================
  Files          28       28              
  Lines         958      964       +6     
==========================================
+ Hits          855      861       +6     
  Misses        103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cycomachead cycomachead merged commit 644ec32 into main Jul 24, 2024
8 checks passed
@cycomachead cycomachead deleted the bug-fixes branch July 24, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant