Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

417 rework command elements #419

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

west270
Copy link
Contributor

@west270 west270 commented Jun 21, 2023

Closes #417

Reworked the ParameterElements for CommandView form to use the FormComponents for consistent styling as the other forms. The resetting issues mentioned in #417 have also been resolved.

Various other issues from the epic #410 should also be resolved.

@west270 west270 marked this pull request as draft June 21, 2023 15:35
@west270 west270 force-pushed the 417-rework-command-elements branch from a0ccc34 to 7a3096e Compare June 21, 2023 16:03
@west270 west270 marked this pull request as ready for review June 21, 2023 16:49
@west270 west270 requested a review from obr42 June 21, 2023 16:49
Copy link
Collaborator

@obr42 obr42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked around on a few different commands, what I saw looked pretty solid. Reset button works well.

@obr42 obr42 merged commit a6c5915 into beer-garden:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change param components to use the form components
2 participants