-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added computing of heading[] fields from new flight attitude quatrernion log data #790
base: master
Are you sure you want to change the base?
Conversation
…ion fields instead of internal IMU
✅ Deploy Preview for origin-blackbox-logviewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
x: srcFrame[imuQuaternion[0]] / scaleFromFixedInt16, | ||
y: srcFrame[imuQuaternion[1]] / scaleFromFixedInt16, | ||
z: srcFrame[imuQuaternion[2]] / scaleFromFixedInt16, | ||
w: 1.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/flightlog.js
Outdated
@@ -735,7 +735,7 @@ export function FlightLog(logData) { | |||
x: srcFrame[imuQuaternion[0]] / scaleFromFixedInt16, | |||
y: srcFrame[imuQuaternion[1]] / scaleFromFixedInt16, | |||
z: srcFrame[imuQuaternion[2]] / scaleFromFixedInt16, | |||
w: 1.0, | |||
w: 0.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also wrong.
Tested on my tiny whoop. |
let gyroADC = [fieldNameToIndex["gyroADC[0]"], fieldNameToIndex["gyroADC[1]"], fieldNameToIndex["gyroADC[2]"]]; | ||
let accSmooth = [fieldNameToIndex["accSmooth[0]"], fieldNameToIndex["accSmooth[1]"], fieldNameToIndex["accSmooth[2]"]]; | ||
let magADC = [fieldNameToIndex["magADC[0]"], fieldNameToIndex["magADC[1]"], fieldNameToIndex["magADC[2]"]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to refactor seeing next line :)
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Quality Gate passedIssues Measures |
The test result of BF, Configurator and explorer work are showed this |
The new testing: |
The improvement for "Added flight IMU pitch, roll, yaw attitudes to blackbox log" BF PR.
The heading[roll, pitch, heading] computed fields are calculated from new flight BF imu quaternion data.
For older logs the older internal BBExplorer IMU are used.