Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSET-5] Add asset images #10

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[ASSET-5] Add asset images #10

merged 2 commits into from
Jan 19, 2024

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented Jan 19, 2024

Pull Request

Description

Script에 몇가지 refactoring과 asset image를 추가합니다.

Related issue: ASSET-5

Changes

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other Update script

Checklist

  • Did you pass the tests?
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?

* ASSET-5 Upgrade python version to 3.12

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Substitute typing_extensions to typing

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Remove asynchrony

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add models and refactor scripts

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add enum ID preprocess

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add tag test

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add address checksum test

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Fix the info to pass the test

Signed-off-by: jormal <jormal@naver.com>

---------

Signed-off-by: jormal <jormal@naver.com>
* ASSET-5 Add exists assets' images

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add images and info

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Update enums

Signed-off-by: jormal <jormal@naver.com>

---------

Signed-off-by: jormal <jormal@naver.com>
@jormal jormal added asset_create Create the asset information settings Set this repository labels Jan 19, 2024
@jormal jormal self-assigned this Jan 19, 2024
@jormal jormal marked this pull request as ready for review January 19, 2024 01:06
@jormal jormal requested a review from a team as a code owner January 19, 2024 01:06
@jormal jormal merged commit 698a63a into main Jan 19, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-5 branch January 19, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset_create Create the asset information settings Set this repository
Development

Successfully merging this pull request may close these issues.

3 participants