Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASSET-10] Set unknown asset ID to each network #11

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[ASSET-10] Set unknown asset ID to each network #11

merged 2 commits into from
Jan 19, 2024

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented Jan 19, 2024 •
edited
Loading

Pull Request

Description

각 network에 unknown asset ID를 세팅합니다.
이를 통해 각 인지된 network 는 별도의 unknown asset icon을 사용할 수 있도록 합니다.

Related issue: ASSET-10

Changes

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other Update asset info

Checklist

  • Did you pass the tests?
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?

@jormal
ASSET-10 Add unknown asset id in network
4f1d1b8 
Signed-off-by: jormal <jormal@naver.com>
@jormal
ASSET-10 Add unknown asset id test
fb581f1 
Signed-off-by: jormal <jormal@naver.com>
@jormal jormal self-assigned this Jan 19, 2024
@jormal jormal added the settings Set this repository label Jan 19, 2024
@jormal jormal marked this pull request as ready for review January 19, 2024 02:02
@jormal jormal requested a review from a team as a code owner January 19, 2024 02:02
@jormal jormal merged commit a86d52f into main Jan 19, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-10 branch January 19, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjkellyjoo yjkellyjoo yjkellyjoo approved these changes

@gihyeonsung gihyeonsung Awaiting requested review from gihyeonsung

@oh51dy oh51dy Awaiting requested review from oh51dy

@zibersaioros zibersaioros Awaiting requested review from zibersaioros

Assignees

@jormal jormal

Labels
settings Set this repository
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jormal @yjkellyjoo