Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASSET-18] Add dependency test #19

Merged
merged 2 commits into from
Apr 22, 2024
Merged

[ASSET-18] Add dependency test #19

merged 2 commits into from
Apr 22, 2024

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented Apr 19, 2024 •
edited
Loading

Pull Request

Description

Requirements list 관리 방법을 IDE 사용측면에서 보다 적합하게 재구성하고,
이를 이용하여 dependency가 항상 잘 유지되는지에 대한 테스트를 추가합니다.

Related issue: ASSET-18

Changes

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other Repository setting

Checklist

  • Did you pass the tests?
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?
  • Have you updated the documentation?
  • Have you updated the version in setup.py if you need?

@jormal
ASSET-18 Update the dependency management method
cbf68da 
Signed-off-by: jormal <jormal@naver.com>
@jormal
ASSET-18 Add tests
c4c9c00 
Signed-off-by: jormal <jormal@naver.com>
@jormal jormal added the settings Set this repository label Apr 19, 2024
@jormal jormal self-assigned this Apr 19, 2024
@jormal jormal marked this pull request as ready for review April 19, 2024 09:54
@jormal jormal requested a review from a team as a code owner April 19, 2024 09:54
@jormal jormal merged commit 12f8c80 into main Apr 22, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-18 branch April 22, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjkellyjoo yjkellyjoo yjkellyjoo approved these changes

@gihyeonsung gihyeonsung Awaiting requested review from gihyeonsung

@luke-yoon luke-yoon Awaiting requested review from luke-yoon

@oh51dy oh51dy Awaiting requested review from oh51dy

@zibersaioros zibersaioros Awaiting requested review from zibersaioros

Assignees

@jormal jormal

Labels
settings Set this repository
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jormal @yjkellyjoo