Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSET-34] Add bitcoin network info #39

Merged
merged 4 commits into from
Jul 23, 2024
Merged

[ASSET-34] Add bitcoin network info #39

merged 4 commits into from
Jul 23, 2024

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented Jul 23, 2024

Pull Request

Description

Bitcoin network info를 추가합니다.

Related issue: ASSET-34

Changes

  • 41546a3: Bitcoin address type 추가
  • 0cfd2d6: Bitcoin network info 추가
  • 8e6e446: Bitcoin asset info 갱신

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other Type setting

Checklist

  • Did you pass the tests? (Did you execute pytest -l in your PC and get a green light?)
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?
  • Have you updated the documentation?
  • Have you updated the version in {PWD}/VERSION if you need?

Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
@jormal jormal added asset_create Create the asset information asset_update Update the asset information settings Set this repository labels Jul 23, 2024
@jormal jormal self-assigned this Jul 23, 2024
@jormal jormal requested a review from a team as a code owner July 23, 2024 05:54
yjkellyjoo
yjkellyjoo previously approved these changes Jul 23, 2024
assets/btc-0/info.json Show resolved Hide resolved
requirements/essential.txt Show resolved Hide resolved
Signed-off-by: jormal <jormal@naver.com>
@jormal
Copy link
Collaborator Author

jormal commented Jul 23, 2024

version 갱신을 안해서 재리뷰 요청드립니다 🙇

@jormal jormal merged commit 2706b78 into main Jul 23, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-34 branch July 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset_create Create the asset information asset_update Update the asset information settings Set this repository
Development

Successfully merging this pull request may close these issues.

2 participants