Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSET-41] Update Polygon network image #46

Merged
merged 4 commits into from
Sep 25, 2024
Merged

[ASSET-41] Update Polygon network image #46

merged 4 commits into from
Sep 25, 2024

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented Sep 25, 2024

Pull Request

Description

Polygon network image를 갱신합니다.

Related issue: ASSET-41

Changes

  • faf6c1b: Polygon reference들의 link key를 갱신합니다.
  • 062d145: Polygon network image를 갱신합니다.

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other {{Please add description here}}

Checklist

  • Did you pass the tests? (Did you execute pytest -l in your PC and get a green light?)
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?
  • Have you updated the documentation?
  • Have you updated the version in {PWD}/VERSION if you need?

Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
@jormal jormal self-assigned this Sep 25, 2024
@jormal jormal added the asset_update Update the asset information label Sep 25, 2024
@jormal jormal marked this pull request as ready for review September 25, 2024 07:03
@jormal jormal requested a review from a team as a code owner September 25, 2024 07:03
yjkellyjoo
yjkellyjoo previously approved these changes Sep 25, 2024
Copy link

@yjkellyjoo yjkellyjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎ..화질이.. 128, 256 png 많이 깨지는 거 같은데 괜찮은건가요..?ㅎ

@jormal
Copy link
Collaborator Author

jormal commented Sep 25, 2024

ㅎ..화질이.. 128, 256 png 많이 깨지는 거 같은데 괜찮은건가요..?ㅎ

음... 그러네요..

Signed-off-by: jormal <jormal@naver.com>
@jormal
Copy link
Collaborator Author

jormal commented Sep 25, 2024

@yjkellyjoo 화질 개선했으니 재리뷰 요청드립니다.

@yjkellyjoo yjkellyjoo self-requested a review September 25, 2024 07:56
@jormal jormal merged commit 5c520b3 into main Sep 25, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-41 branch September 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset_update Update the asset information
Development

Successfully merging this pull request may close these issues.

2 participants