BIP 300/301: Link to latest code -- also shorter/better explanations #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jonatack
reviewed
Sep 23, 2024
There was a problem hiding this comment.
The changes appear globally good. Didn't do a technical review but rather a first editor pass.
In general, it may be nice to write "transaction" in lieu of "txn", and possibly define the L1 and L2 abbreviations near the top of each BIP to clarify if they refer to their usual meaning or a different one in this context.
Co-authored-by: Jon Atack <jon@atack.com>
Co-authored-by: Jon Atack <jon@atack.com>
|
Thanks, I added all of those changes, except for one (the "32-bytes" one) , and the "one byte" --> "1 byte" area I accepted the change and then changed it slightly more. |
jonatack
reviewed
Sep 23, 2024
Co-authored-by: Jon Atack <jon@atack.com>
|
Ok those were also good changes
I think merge it, whenever is convenient for you |
|
ACK, thanks. |
jonatack
changed the title
akarve
pushed a commit
to akarve/bips
that referenced
this pull request
Sep 24, 2024
* Update to CUSF activation client +shorter +clearer * remove superfluous images * link to CUSF client, shorter and clearer BIP text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've developed a much cleaner/safer/better way of doing BIP-300/301, and updated the BIP accordingly.
While doing that, I have updated the BIP text to (hopefully) clarify a number of points/questions that were raised over the last 12 months.