BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity #1679

akarve · 2024-10-07T00:09:18Z

Reloading this PR with minimal, backward-compatible changes.

I believe there is consensus on the need to add a new champion here.
The reason for adding a new reference implementation is to support Python 3.x with a thoroughly unit-tested implementation. I was unable to get the original Python 2.x reference implementation to run.
If desired I can email bitcoin dev for more thoughts on these changes

akarve · 2024-10-07T00:17:44Z

scgbckbone

wrong entropy is in base64 pwd application, currently:
d7ad61d4a76575c5bad773feeb40299490b224e8e5df6c8ad8fe3d0a6eed7b85ead9fef7bcca8160f0ee48dc6e92b311fc71f2146623cc6952c03ce82c7b63fe

correct:
74a2e87a9ba0cdd549bdd2f9ea880d554c6c355b08ed25088cfa88f3f1c4f74632b652fd4a8f5fda43074c6f6964a3753b08bb5210c8f5e75c07a4c2a20bf6e9

bip-0085.mediawiki

scgbckbone · 2024-10-07T17:54:25Z

could you possibly split this into "b64 entropy fix only PR" and "the rest" ?

akarve · 2024-10-07T19:23:17Z

could you possibly split this into "b64 entropy fix only PR" and "the rest" ?

Yeah~~but I’d also include the BIP32 comment because it’s a fact~~.

jonatack

Thank you for opening this, was going to ask. If this is to be done, seems best to do it before updating the BIP status to Final in #1676.

Can you prefix each commit message with BIP85: or refer to it in the commit title?
Consider doing the test vector correction in a separate commit with a full explanation of what was incorrect and the fix.
Can you also provide an explanation of the Base64 entropy fix in the commit message.
Please provide a better commit message for the "add warning" commit.
Did you want to make the changes in the abstract and definitions sections that you did in BIP85: Clarify spec, correct test vectors, add Portuguese language code, add dice application #1600?

cc @nvk for review

bip-0085.mediawiki

scgbckbone · 2024-10-08T13:54:49Z

Can you also provide an explanation of the Base64 entropy fix in the commit message.

@jonatack this is my bug when I was adding base64 app to the BIP, seems it went unnoticed for long time...

…rammar clarity

akarve · 2024-10-14T00:03:51Z

Can you also provide an explanation of the Base64 entropy fix in the commit message.

@jonatack this is my bug when I was adding base64 app to the BIP, seems it went unnoticed for long time...

Here's the standalone fix: #1683

akarve · 2024-10-14T00:05:25Z

Did you want to make the changes in the abstract and definitions sections that you did in #1600?

I want to ~~but not in this changeset. Let's get through the hard parts then we can optimize on top of that. I'm tryna keep the changesets as small as possible for now.~~

jonatack · 2024-10-15T17:14:01Z

Might be good to add a changelog in this pull, as previously in #1600.

bip-0085.mediawiki

Co-authored-by: Jon Atack <jon@atack.com>

jonatack

Ok, I see that https://github.com/akarve/bipsea has been updated.

bip-0085.mediawiki

akarve · 2024-10-21T20:16:05Z

@jonatack thanks for the careful reviews. i think we're g2g. do committers squash and merge? if not should i rebase this? I was asked to preface all commits with BIP-85, and these commits are all orthogonal and semantic, but I personally would prefer a rebase because a lot of this is TMI for master, agree?

bip-0085.mediawiki

jonatack

do committers squash and merge? if not should i rebase this? I was asked to preface all commits with BIP-85, and these commits are all orthogonal and semantic, but I personally would prefer a rebase because a lot of this is TMI for master, agree?

People have different preferences. I prefer when the PR author organizes the commits in a logical, hygienic manner; and otherwise, I might squash in the merge to one commit.

bip-0085.mediawiki

Co-authored-by: Jon Atack <jon@atack.com>

…password example to dice

akarve · 2024-10-22T22:58:03Z

bip-0085.mediawiki

@@ -370,16 +429,42 @@ The reason for running the derived key through HMAC-SHA512 and truncating the re

 Many thanks to Peter Gray and Christopher Allen for their input, and to Peter for suggesting extra application use cases.

+==Change Log==


@jonatack i've added a real changelog so that the semvers are more... semantic. i could go deeper in terms of detail (fixes, etc.) but this seems complete enough to be useful and importantly puts this commit at semver 1.3.0.

Suggest "Changelog" (no space), with entries ordered by most recent first (see https://keepachangelog.com/en/1.1.0/).

bip-0085.mediawiki

…th BIP32 warning

jonatack

Seems close, modulo a couple suggestions.

Pinging @scgbckbone @nvk @Rob1Ham @luisschwab for review/comments.

Reviewers: suggest looking at the whole change, not commit-by-commit.

jonatack · 2024-10-24T21:35:27Z

bip-0085.mediawiki

-* JavaScript library implementation: [https://github.com/hoganri/bip85-js]
+* 1.3.0 Python 3.x library implementation: [https://github.com/akarve/bipsea]
+* 1.1.0 Python 2.x library implementation: [https://github.com/ethankosakovsky/bip85]
+* 1.0.0 JavaScript library implementation: [https://github.com/hoganri/bip85-js]


Perhaps it would be easier for readers to reference these versions by moving this Reference Implementation section to just above the Changelog (and move the Acknowledgements section further down toward the end).

jonatack · 2024-10-24T21:41:40Z

bip-0085.mediawiki

@@ -370,16 +429,42 @@ The reason for running the derived key through HMAC-SHA512 and truncating the re

 Many thanks to Peter Gray and Christopher Allen for their input, and to Peter for suggesting extra application use cases.

+==Change Log==


Suggest "Changelog" (no space), with entries ordered by most recent first (see https://keepachangelog.com/en/1.1.0/).

scgbckbone

ACK (but expect #1676 to follow)

jonatack

Thanks for looking @scgbckbone.

ACK 0e5f2da

akarve mentioned this pull request Oct 7, 2024

BIP85: revert XPRV breaking changes for application 32' #1673

Closed

scgbckbone suggested changes Oct 7, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

akarve requested a review from scgbckbone October 7, 2024 02:31

jonatack reviewed Oct 7, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

jonatack mentioned this pull request Oct 7, 2024

BIP85: update status to Final #1676

Merged

jonatack added the PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author label Oct 9, 2024

BIP-85: Add language code, add dice app, warn on BIP-32 divergence, g…

274d9b9

…rammar clarity

akarve force-pushed the bip85-fixes branch from 6c4a808 to 274d9b9 Compare October 13, 2024 23:55

akarve changed the title ~~BIP-85: Correct test vector, add language code, add dice app~~ BIP-85: Add language code, add dice app, warn on BIP-32 divergence, grammar clarity Oct 13, 2024

akarve requested a review from jonatack October 13, 2024 23:56

akarve changed the title ~~BIP-85: Add language code, add dice app, warn on BIP-32 divergence, grammar clarity~~ BIP-85: Add language code, add dice app, warn on BIP-32 divergence, grammar & clarity Oct 14, 2024

jonatack mentioned this pull request Oct 15, 2024

BIP-85: Correct bad test vector for Base64 #1683

Merged

jonatack reviewed Oct 15, 2024

View reviewed changes

bip-0085.mediawiki Show resolved Hide resolved

jonatack reviewed Oct 15, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

jonatack reviewed Oct 15, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

akarve and others added 3 commits October 15, 2024 11:10

BIP-85: Add definite article

503d936

Co-authored-by: Jon Atack <jon@atack.com>

BIP-85: PR suggestions on grammar, clarity

c29be89

BIP-85: Add change log

c5a74ff

akarve requested a review from jonatack October 15, 2024 18:26

akarve changed the title ~~BIP-85: Add language code, add dice app, warn on BIP-32 divergence, grammar & clarity~~ BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity Oct 15, 2024

jodyyates approved these changes Oct 16, 2024

View reviewed changes

jonatack reviewed Oct 17, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

bip-0085.mediawiki Outdated Show resolved Hide resolved

bip-0085.mediawiki Outdated Show resolved Hide resolved

akarve requested a review from jonatack October 20, 2024 22:44

akarve commented Oct 21, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

BIP-85: PR grammar improvements

a645d94

akarve commented Oct 21, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

BIP-85: Add dice app code to changelog

819f7b7

jonatack reviewed Oct 22, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

bip-0085.mediawiki Outdated Show resolved Hide resolved

bip-0085.mediawiki Outdated Show resolved Hide resolved

jonatack reviewed Oct 22, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

bip-0085.mediawiki Outdated Show resolved Hide resolved

bip-0085.mediawiki Outdated Show resolved Hide resolved

akarve and others added 4 commits October 22, 2024 15:34

BIP-85: Grammar and clarity from PR review

34b7477

Co-authored-by: Jon Atack <jon@atack.com>

BIP-85: Improve changelog and bump semvers accordingly; add alphanum …

3221abe

…password example to dice

BIP-85: Rectify changelog dates and contents

f9df9a7

BIP-85: Correct 1.3.0 semver in changelog

f763695

akarve commented Oct 22, 2024

View reviewed changes

akarve requested a review from jonatack October 22, 2024 22:58

akarve commented Oct 22, 2024

View reviewed changes

bip-0085.mediawiki Outdated Show resolved Hide resolved

akarve added 2 commits October 22, 2024 16:15

BIP-85: Remove fancy warning syntax b/c GH doesn't render it, wordsmi…

294db30

…th BIP32 warning

BIP-85: Add and correct semvers in Reference Implementation section

0e5f2da

jonatack reviewed Oct 24, 2024

View reviewed changes

jonatack added Proposed BIP modification and removed PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author labels Oct 25, 2024

scgbckbone approved these changes Oct 25, 2024

View reviewed changes

jonatack reviewed Oct 25, 2024

View reviewed changes

jonatack merged commit 8eac367 into bitcoin:master Oct 25, 2024
4 checks passed

akarve deleted the bip85-fixes branch October 25, 2024 15:48

akarve mentioned this pull request Oct 25, 2024

BIP-85: formatting and changelog updates, and add word cases for application 39' #1691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity #1679

BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity #1679

akarve commented Oct 7, 2024 •

edited

Loading

akarve commented Oct 7, 2024

scgbckbone left a comment

scgbckbone commented Oct 7, 2024

akarve commented Oct 7, 2024 •

edited

Loading

jonatack left a comment

scgbckbone commented Oct 8, 2024

akarve commented Oct 14, 2024

akarve commented Oct 14, 2024 •

edited

Loading

jonatack commented Oct 15, 2024 •

edited

Loading

jonatack left a comment

akarve commented Oct 21, 2024 •

edited

Loading

jonatack left a comment

akarve Oct 22, 2024 •

edited

Loading

jonatack Oct 24, 2024

jonatack left a comment •

edited

Loading

jonatack Oct 24, 2024 •

edited

Loading

jonatack Oct 24, 2024

scgbckbone left a comment

jonatack left a comment

This comment was marked as spam.

This comment was marked as spam.

		@@ -370,16 +429,42 @@ The reason for running the derived key through HMAC-SHA512 and truncating the re

		Many thanks to Peter Gray and Christopher Allen for their input, and to Peter for suggesting extra application use cases.

		==Change Log==

BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity #1679

BIP-85: Add language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity #1679

Conversation

akarve commented Oct 7, 2024 • edited Loading

akarve commented Oct 7, 2024

scgbckbone left a comment

Choose a reason for hiding this comment

scgbckbone commented Oct 7, 2024

akarve commented Oct 7, 2024 • edited Loading

jonatack left a comment

Choose a reason for hiding this comment

scgbckbone commented Oct 8, 2024

akarve commented Oct 14, 2024

akarve commented Oct 14, 2024 • edited Loading

jonatack commented Oct 15, 2024 • edited Loading

jonatack left a comment

Choose a reason for hiding this comment

akarve commented Oct 21, 2024 • edited Loading

jonatack left a comment

Choose a reason for hiding this comment

akarve Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

jonatack Oct 24, 2024

Choose a reason for hiding this comment

jonatack left a comment • edited Loading

Choose a reason for hiding this comment

jonatack Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

jonatack Oct 24, 2024

Choose a reason for hiding this comment

scgbckbone left a comment

Choose a reason for hiding this comment

jonatack left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

akarve commented Oct 7, 2024 •

edited

Loading

akarve commented Oct 7, 2024 •

edited

Loading

akarve commented Oct 14, 2024 •

edited

Loading

jonatack commented Oct 15, 2024 •

edited

Loading

akarve commented Oct 21, 2024 •

edited

Loading

akarve Oct 22, 2024 •

edited

Loading

jonatack left a comment •

edited

Loading

jonatack Oct 24, 2024 •

edited

Loading